Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wgpu to v0.19.3 and unpin web-sys. #65

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Conversation

xStrom
Copy link
Contributor

@xStrom xStrom commented Mar 23, 2024

wgpu used to depend on unstable web-sys features which don't follow SemVer. However things have changed, wgpu has now vendored those bindings. This was also backported and released as v0.19.3.

This means that pinning web-sys is no longer required. The following can be done:

  • Update the wgpu requirement to 0.19.3.
  • Remove the web-sys pin.

Doing so will unlock the ability for unrelated projects that have wgpu-profiler in their workspace to finally update their web-sys.

Also, an additional benefit of the aforementioned wgpu change is that wgpu no longer requires you to have --cfg=web_sys_unstable_apis in your RUSTFLAGS.

Copy link
Owner

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@Wumpf Wumpf merged commit c1c7b03 into Wumpf:main Mar 24, 2024
1 check passed
@xStrom xStrom deleted the wgpu193 branch March 24, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants